Skip to content

HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false#2205

Merged
umamaheswararao merged 2 commits intoapache:trunkfrom
umamaheswararao:HDFS-15515
Aug 11, 2020
Merged

HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false#2205
umamaheswararao merged 2 commits intoapache:trunkfrom
umamaheswararao:HDFS-15515

Conversation

@umamaheswararao
Copy link
Contributor

@umamaheswararao umamaheswararao commented Aug 10, 2020

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 10, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 27m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 20s Maven dependency ordering for branch
+1 💚 mvninstall 31m 58s trunk passed
+1 💚 compile 27m 9s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 22m 22s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 3m 27s trunk passed
+1 💚 mvnsite 3m 34s trunk passed
+1 💚 shadedclient 25m 25s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 9s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 3m 18s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 4m 9s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 6m 46s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 2m 32s the patch passed
+1 💚 compile 21m 54s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 21m 54s the patch passed
+1 💚 compile 16m 54s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 16m 54s the patch passed
+1 💚 checkstyle 2m 40s the patch passed
+1 💚 mvnsite 2m 55s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 13m 46s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 16s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 3m 15s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 5m 35s the patch passed
_ Other Tests _
+1 💚 unit 9m 19s hadoop-common in the patch passed.
-1 ❌ unit 97m 31s hadoop-hdfs in the patch passed.
+1 💚 asflicense 1m 1s The patch does not generate ASF License warnings.
333m 33s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestFSImage
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.TestDFSUpgradeFromImage
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
hadoop.hdfs.TestStripedFileAppend
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2205/1/artifact/out/Dockerfile
GITHUB PR #2205
JIRA Issue HDFS-15515
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux c9e8982fc06c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 5e0f879
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2205/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2205/1/testReport/
Max. process+thread count 4107 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2205/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @umamaheswararao for the work here.
Chnages LGTM, test failures seems unrelated.
+1

steveloughran
steveloughran reviewed Aug 10, 2020
View reviewed changes
...ct/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemLinkFallback.java
// attempt to create in fallback.
assertFalse(vfs.mkdirs(nextLevelToInternalDir));
try {
vfs.mkdirs(nextLevelToInternalDir);
Copy link
Contributor

@steveloughran steveloughran Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use LambdaTestUtils.intercept()

Copy link
Contributor Author

@umamaheswararao umamaheswararao Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

@steveloughran
Copy link
Contributor

steveloughran commented Aug 10, 2020

LGTM-just change the test to use intercept()

@hemanthboyina
Copy link
Contributor

hemanthboyina commented Aug 10, 2020

+1 after changing to intercept()

@hadoop-yetus
Copy link

hadoop-yetus commented Aug 10, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 1s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 18s Maven dependency ordering for branch
+1 💚 mvninstall 26m 19s trunk passed
+1 💚 compile 19m 26s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 16m 39s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 checkstyle 2m 41s trunk passed
+1 💚 mvnsite 2m 58s trunk passed
+1 💚 shadedclient 20m 14s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 16s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 3m 8s trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗 spotbugs 3m 9s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 21s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for patch
+1 💚 mvninstall 1m 59s the patch passed
+1 💚 compile 18m 49s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 18m 49s the patch passed
+1 💚 compile 16m 52s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 javac 16m 52s the patch passed
+1 💚 checkstyle 2m 36s the patch passed
+1 💚 mvnsite 2m 52s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 17s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 14s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 3m 9s the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚 findbugs 5m 43s the patch passed
_ Other Tests _
+1 💚 unit 9m 58s hadoop-common in the patch passed.
-1 ❌ unit 117m 11s hadoop-hdfs in the patch passed.
+1 💚 asflicense 1m 5s The patch does not generate ASF License warnings.
298m 19s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMXBean
hadoop.hdfs.TestGetFileChecksum
hadoop.hdfs.TestStripedFileAppend
hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
hadoop.hdfs.TestMultipleNNPortQOP
hadoop.hdfs.server.datanode.TestBPOfferService
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2205/2/artifact/out/Dockerfile
GITHUB PR #2205
JIRA Issue HDFS-15515
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 81dfe104f4b6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 5e0f879
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2205/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2205/2/testReport/
Max. process+thread count 3850 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2205/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@umamaheswararao umamaheswararao merged commit 8955a6c into apache:trunk Aug 11, 2020
asfgit pushed a commit that referenced this pull request Aug 13, 2020
@umamaheswararao @steveloughran
HDFS-15515: mkdirs on fallback should throw IOE out instead of suppre…
99b120a 
…ssing and returning false (#2205)

* HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false

* Used LambdaTestUtils#intercept in test
umamaheswararao added a commit that referenced this pull request Aug 25, 2020
@umamaheswararao
HDFS-15515: mkdirs on fallback should throw IOE out instead of suppre…
978ce5a 
…ssing and returning false (#2205)

* HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false

* Used LambdaTestUtils#intercept in test

(cherry picked from commit 99b120a)
umamaheswararao added a commit that referenced this pull request Aug 25, 2020
@umamaheswararao
HDFS-15515: mkdirs on fallback should throw IOE out instead of suppre…
0808cb6 
…ssing and returning false (#2205)

* HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false

* Used LambdaTestUtils#intercept in test

(cherry picked from commit 99b120a)
@huangtianhua huangtianhua mentioned this pull request Sep 11, 2020
Merged
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@umamaheswararao @umagangumalla
HDFS-15515: mkdirs on fallback should throw IOE out instead of suppre…
0cdca06 
…ssing and returning false (apache#2205)

* HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false

* Used LambdaTestUtils#intercept in test

(cherry picked from commit 8955a6c)
Change-Id: I9e8e340f6f5b7d42bdca632d6983543b3548aa4d
(cherry picked from commit 0538650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveloughran steveloughran steveloughran left review comments

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@umamaheswararao @hadoop-yetus @steveloughran @hemanthboyina @ayushtkn